Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Optional Automation Mode user authentication check #300

Merged
merged 1 commit into from
May 8, 2024
Merged

fix: Optional Automation Mode user authentication check #300

merged 1 commit into from
May 8, 2024

Conversation

a-fultz
Copy link
Contributor

@a-fultz a-fultz commented May 7, 2024

Users running appium driver doctor mac2 are warned to run automationmodetool enable-automationmode-without-authentication based on whether the system is in Automation Mode at the time of the check, not whether user authentication is required for it. From the automationmodetool man page:

If no argument is passed, the tool prints the current status of Automation Mode (enabled or disabled), the authentication configuration (required or not), and then exits.

Example:

% automationmodetool
Automation Mode is disabled.
This device DOES NOT REQUIRE user authentication to enable Automation Mode.

This PR changes the stdout check to 'DOES NOT REQUIRE' and inverts the warning logic.

Note: This code is untested. I do not have a local development environment for Appium or Appium drivers.

Check whether Authentication Mode requires user authentication.
Copy link

linux-foundation-easycla bot commented May 7, 2024

CLA Signed


The committers listed above are authorized under a signed CLA.

@mykola-mokhnach mykola-mokhnach changed the title Fix for optional Automation Mode user authentication check. fix: Optional Automation Mode user authentication check. May 8, 2024
@mykola-mokhnach mykola-mokhnach changed the title fix: Optional Automation Mode user authentication check. fix: Optional Automation Mode user authentication check May 8, 2024
@mykola-mokhnach mykola-mokhnach merged commit 339c5c9 into appium:master May 8, 2024
5 of 11 checks passed
Copy link

github-actions bot commented May 8, 2024

🎉 This PR is included in version 1.17.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@a-fultz a-fultz deleted the patch-2 branch August 16, 2024 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants